fix(windows): WASAPI 16-bit PCM fallback and CLAP scan JSON extraction - #2
Open
lxndrbe wants to merge 1 commit into
Open
fix(windows): WASAPI 16-bit PCM fallback and CLAP scan JSON extraction#2lxndrbe wants to merge 1 commit into
lxndrbe wants to merge 1 commit into
Conversation
Two Windows-specific fixes:
1. WASAPI: Fall back to 16-bit integer PCM when the audio device does
not support 32-bit IEEE float. Most consumer onboard audio devices
(Realtek, etc.) only support 16/24-bit integer formats in shared mode.
The hardcoded 32-bit float format caused 'WASAPI device does not support
32-bit float at 48000 Hz' and AUDCLNT_E_UNSUPPORTED_FORMAT errors.
2. CLAP scan: Extract JSON payload from mixed stdout. CLAP plugin DLLs
(e.g. Charlatan3) write debug output to stdout during DllMain/init,
which corrupts the JSON output from the plugin-host scanner. Now we
locate the first '{' and parse from that position onward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two Windows-specific fixes:
WASAPI: Fall back to 16-bit integer PCM when the audio device does
not support 32-bit IEEE float. Most consumer onboard audio devices
(Realtek, etc.) only support 16/24-bit integer formats in shared mode.
The hardcoded 32-bit float format caused 'WASAPI device does not support
32-bit float at 48000 Hz' and AUDCLNT_E_UNSUPPORTED_FORMAT errors.
CLAP scan: Extract JSON payload from mixed stdout. CLAP plugin DLLs
(e.g. Charlatan3) write debug output to stdout during DllMain/init,
which corrupts the JSON output from the plugin-host scanner. Now we
locate the first '{' and parse from that position onward.
Both fixes tested on Windows 11.